Add missing calculated value in paternity calculator #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsure that questions with interpolated values are rendered correctly. Add test helper method #question_title reads the value of a question as a String, forcing the interpolation to occur, so it can be asserted with a has_content? matcher in integration tests.
erkde
force-pushed
the
add_test_for_interpolation_in_question_titles_for_maternity_paternity_and_adoption
branch
from
6d18e5f to
7f5c483
Compare
|
Looks good to me, @erik-eide! |
erkde
added a commit
that referenced
this pull request
Nov 6, 2015
…question_titles_for_maternity_paternity_and_adoption Add missing calculated value in paternity calculator
erkde
deleted the
add_test_for_interpolation_in_question_titles_for_maternity_paternity_and_adoption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to the adoption, maternity and paternity smart answers to ensure that questions with interpolated values are rendered correctly.
Adds a test helper method #question_title reads the value of a question as a String, forcing the interpolation to occur, so it can be asserted with a has_content? matcher in integration tests.
Updates the paternity calculator, adding the missing calculated value that is interpolated into the question title.
Verify step
Example URL