Correctly pluralise values in calculate-your-holiday-entitlement #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't find any reference to this in PT or Zendesk. I've asked in the #content Slack channel to see who knows about it. |
|
It just was something 2nd line pointed out during the last deploy, currently it shows '1 days' or similar in several of the outcomes when the value is singular but the measure is plural. For example: https://www.gov.uk/calculate-your-holiday-entitlement/y/days-worked-per-week/full-year/0.17 |
@erik-eide noticed that we were always displaying the plural of "shifts", "days", "hours" and "minutes" in the outcomes of this Smart Answer. This change uses the `pluralize` helper so that we correctly display the singular or plural version of each of those words. There were no changes to regression test artefacts, presumably because we only ever test with quantities of more than 1.
chrisroos
force-pushed
the
fix_holiday_entitlement_pluralization
branch
from
cc5b29a to
305a673
Compare
|
I've rebased on master and force pushed in preparation for merging. |
chrisroos
changed the title
|
Thanks for the update @erik-eide. I hope you don't mind but I've updated the commit message to explain that this was something you noticed. I'm going to merge this to master as soon as the tests pass. |
chrisroos
added a commit
that referenced
this pull request
Nov 12, 2015
…ization Correctly pluralise values in calculate-your-holiday-entitlement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected changes