Use next_node blocks in energy-grants-calculator #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than my minor comment, this LGTM 👍 |
I've replaced `define_predicate` with `next_node_calculation` in an attempt to keep the code as similar as possible. I've had to update the names used by `next_node_calculation` as the question marks cause problems when the state object is converted to a hash in preparation for rendering the ERB templates.
I've replaced `define_predicate` with `next_node_calculation` in an attempt to keep the code as similar as possible. I've had to update the names used by `next_node_calculation` as the question marks cause problems when the state object is converted to a hash in preparation for rendering the ERB templates.
I've replaced `define_predicate` with `next_node_calculation` in an attempt to keep the code as similar as possible. I've had to update the names used by `next_node_calculation` as the question marks cause problems when the state object is converted to a hash in preparation for rendering the ERB templates.
I've replaced `define_predicate` with `next_node_calculation` in an attempt to keep the code as similar as possible. I've had to update the names used by `next_node_calculation` as the question marks cause problems when the state object is converted to a hash in preparation for rendering the ERB templates.
I've replaced `define_predicate` with `next_node_calculation` in an attempt to keep the code as similar as possible. I've had to update the names used by `next_node_calculation` as the question marks cause problems when the state object is converted to a hash in preparation for rendering the ERB templates.
chrisroos
force-pushed
the
use-next-node-blocks-in-energy-grants-calculator
branch
from
557a459 to
8175a28
Compare
|
I've rebased on master and force pushed in preparation for merging. |
chrisroos
added a commit
that referenced
this pull request
Nov 11, 2015
…-grants-calculator Use next_node blocks in energy-grants-calculator
chrisroos
deleted the
use-next-node-blocks-in-energy-grants-calculator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've agreed to consistently use
next_node {}to define our next node rules. Having a single way of defining the rules will hopefully make Smart Answers easier to develop and maintain.This will ultimately allow us to remove the predicate code (
define_predicate,on_condition,next_node_ifetc).Expected observable changes