Use next_node blocks in check-uk-visa #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note the three sets of "rules" in the `next_node` block. I've had to split it like this to replicate the existing behaviour. Splitting the rules like this has meant that I've had to use `next` to return early from the `next_node` block in the first `case` statement, and second `if` statement.
I've used `next :outcome_visit_waiver` to exit the block early if `passport_country == 'taiwan'`. This is to avoid having to nest the following `case` statement in an `else` statement.
chrisroos
added a commit
that referenced
this pull request
Nov 12, 2015
…uk-visa Use next node blocks in check uk visa
chrisroos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes PR #2066 now that I've rebased on master. I've left the old PR so that we retain comments.
Expected observable changes