Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Rails patch release 4.2.5 #2084

Merged
merged 1 commit into from
Nov 17, 2015
Merged

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Nov 12, 2015

Updates smart answers to the use the latest patch release of Ruby on Rails.

Changelog links:

The url_for method no longer modifies arguments in polymorphic URLs but it doesn't seem to effect smart answers.

Seems to be mostly ActiveRecored relation changes.

Expected changes

  • none

@floehopper floehopper self-assigned this Nov 16, 2015
@floehopper
Copy link
Contributor

Looks good to me, although it'd be good to make sure the regression tests all pass before deploying.

@erkde erkde force-pushed the update_to_rails_4_2_5 branch from 2f97e64 to dc4b4a0 Compare November 17, 2015 06:23
@erkde
Copy link
Contributor Author

erkde commented Nov 17, 2015

Rebased with master, the regression seem ok:

Finished in 4435.497196s, 4.9388 runs/s, 0.0257 assertions/s.

21906 runs, 114 assertions, 0 failures, 0 errors, 0 skips

erkde added a commit that referenced this pull request Nov 17, 2015
Update to latest Rails patch release 4.2.5
@erkde erkde merged commit 23516f8 into master Nov 17, 2015
@erkde erkde deleted the update_to_rails_4_2_5 branch November 17, 2015 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants