Improve test coverage for FormattingHelper#format_money #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
I believe that the origin of the code in `FormattingHelper#format_money` was from the code which is now in `SmartAnswer::I18nRenderer#value_for_interpolation`. Thus at least in some scenarios I would expect a `SmartAnswer::Money` object to be passed in rather than a `String`. This commit adds assertions for the former. [1]: https://github.com/alphagov/smart-answers/blob/7e26c554be106b2888f44bf92746e5fc7f6d819f/lib/smart_answer/i18n_renderer.rb#L33-L34
floehopper
force-pushed
the
improve-test-coverage-for-formatting-helper-test
branch
from
c908d30 to
8edbbe1
Compare
|
I've rebased this against master and force-pushed in preparation for merging. |
floehopper
added a commit
that referenced
this pull request
Nov 16, 2015
…atting-helper-test Improve test coverage for FormattingHelper#format_money
floehopper
deleted the
improve-test-coverage-for-formatting-helper-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the origin of the code in
FormattingHelper#format_moneywasfrom the code which is now in
SmartAnswer::I18nRenderer#value_for_interpolation.Thus at least in some scenarios I would expect a
SmartAnswer::Moneyobject to bepassed in rather than a
String. This commit adds assertions for the former.Expected observable changes