Avoid relying on old fallback behaviour for question title #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
Since [1] we no longer fallback to the humanized version of the question name, so it doesn't make sense to rely on that behaviour. Also by asserting against a string literal we can avoid delving into the internals of the flow. [1]: aad10d5
floehopper
force-pushed
the
fix-assertion-relying-on-old-fallback-behaviour-for-question-titles
branch
from
b4c6165 to
bbe8122
Compare
|
I've rebased this against master and force-pushed in preparation for merging. |
floehopper
added a commit
that referenced
this pull request
Nov 16, 2015
…allback-behaviour-for-question-titles Avoid relying on old fallback behaviour for question title
floehopper
deleted the
fix-assertion-relying-on-old-fallback-behaviour-for-question-titles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this commit we no longer fallback to the humanized version of the question name,
so it doesn't make sense to rely on that behaviour.
Also by asserting against a string literal we can avoid delving into the
internals of the flow.
Expected observable changes