Name the app that's deployed to Heroku #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
|
I've realised that I should update the documentation in factcheck.md as part of this branch. |
chrisroos
force-pushed
the
name-the-deployed-heroku-app
branch
from
f82052d to
9b872d7
Compare
|
I've made a couple of changes to this branch. I'd appreciate you taking another look when you have a moment, @floehopper. |
|
LGTM 👍 |
Naming the app using the pull request number should ensure the names are unique and also easily guessable/discoverable. I'm passing the `--app` option to the `heroku` commands in preparation for also naming the git remote so that we can potentially have multiple heroku apps running at once.
This should make it easier to have multiple pull requests deployed to Heroku at one time.
To explain that you need to pass the GitHub pull request number to the `startup_heroku.sh` script.
chrisroos
force-pushed
the
name-the-deployed-heroku-app
branch
from
9b872d7 to
7ffbaf1
Compare
|
I've rebased on master and force-pushed in preparation for merging to master. |
|
The test failure was to do with the problem described and fixed in PR #2107. I'm going to merge this to master. |
chrisroos
added a commit
that referenced
this pull request
Nov 18, 2015
Name the app that's deployed to Heroku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming the app using the pull request number should ensure the names are
unique but also easily guessable/discoverable.