Update register-a-birth oru_result outcome #2101
Merged
+1,647
−2,470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroos
force-pushed
the
update-register-a-birth-oru-result-outcome
branch
from
cc9c60d to
37165f0
Compare
|
Other than my minor comments, this looks good to me. |
chrisroos
force-pushed
the
update-register-a-birth-oru-result-outcome
branch
from
37165f0 to
b02dad3
Compare
|
I've updated this branch based on @floehopper's feedback. |
|
These test failures are to do with the problem fixed in PR #2107. I've scheduled another build on Jenkins. |
chrisroos
force-pushed
the
update-register-a-birth-oru-result-outcome
branch
from
b02dad3 to
f13cb78
Compare
|
I've rebased this on master and force pushed to avoid it from getting too out of date. |
PT story: https://www.pivotaltracker.com/story/show/108010578 The story in Pivotal includes these changes but not the motivation for them. I'll update the regression test artefacts in a separate commit as there are a lot of changes.
These changes are the result of the change to the
oru_result.govspeak.erb outcome in the commit titled "Update copy in
register-a-birth oru_result outcome".
The artefacts have been updated for the following countries:
* afghanistan
* algeria
* libya
* morocco
* north-korea
* papua-new-guinea
* philippines
* sierra-leone
* st-martin
* timor-leste
* usa
* venezuela
The list above was generated using:
$ git show --numstat | \
grep "test/artefacts" | \
cut -d"/" -f4 | \
sort | \
uniq
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
register-a-birth
chrisroos
force-pushed
the
update-register-a-birth-oru-result-outcome
branch
from
f13cb78 to
162a0e1
Compare
|
I've made a minor change to oru_result.govspeak.erb based on feedback from FCO. I've also rebased on master and force-pushed in preparation for merging. |
chrisroos
added a commit
that referenced
this pull request
Nov 26, 2015
…sult-outcome Update register-a-birth oru_result outcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT story: https://www.pivotaltracker.com/story/show/108010578
Fact check
This branch affects outcomes for the following countries:
Expected user-facing changes
Before
After