Fix FlowRegistrationPresenter to work with both i18n & ERB #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
In #2103 I forgot that we still need to support flows/questions with their content in i18n YAML files vs ERB templates. In this commit I've renamed the `FlowRegistrationPresenterTest` to `FlowRegistrationPresenterWithErbRendererTest` and reinstated the earlier version of `FlowRegistrationPresenterTest` to give suitable test coverage. I've also reinstated the two i18n YAML files and use an explicit call to `Flow#use_erb_templates_for_questions` in `FlowRegistrationPresenterWithErbRendererTest` to switch over to ERB rendering. Finally I've also reinstated the handling of `I18n::MissingInterpolationArgument` so that the tests all pass.
floehopper
force-pushed
the
fix-flow-registration-presenter
branch
from
cc24439 to
2b1ae94
Compare
|
I've rebased this against master and force-pushed in preparation for merging. |
floehopper
added a commit
that referenced
this pull request
Nov 19, 2015
Fix FlowRegistrationPresenter to work with both i18n & ERB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2103 I forgot that we still need to support flows/questions with their
content in i18n YAML files vs ERB templates.
In this commit I've renamed the
FlowRegistrationPresenterTesttoFlowRegistrationPresenterWithErbRendererTestand reinstated the earlierversion of
FlowRegistrationPresenterTestto give suitable test coverage.I've also reinstated the two i18n YAML files and use an explicit call to
Flow#use_erb_templates_for_questionsinFlowRegistrationPresenterWithErbRendererTestto switch over to ERB rendering.Finally I've also reinstated the handling of
I18n::MissingInterpolationArgumentso that the tests all pass.Note that we saw an exception in preview which alerted me to this problem.