Convert part-year-profit-tax-credits to use ERB templates for questions #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
This was causing me problems when I tried to make the change to use an ERB template for the question, because some of the setup in the second context was needed by the tests in the first context. This is because when any question attribute is accessed, the whole ERB template has to be rendered.
I ran the following command:
$ rails r script/convert-question-i18-yaml-to-erb-templates.rb lib/smart_answer_flows/part-year-profit-tax-credits
Writing template: when_did_your_tax_credits_award_end.govspeak.erb
Writing template: have_you_stopped_trading.govspeak.erb
Writing template: did_you_start_trading_before_the_relevant_accounting_year.govspeak.erb (WARNING: contains interpolation)
Writing template: when_did_you_stop_trading.govspeak.erb (WARNING: contains interpolation)
Writing template: what_date_do_your_accounts_go_up_to.govspeak.erb
Writing template: do_your_accounts_cover_a_12_month_period.govspeak.erb (WARNING: contains interpolation)
Writing template: when_did_you_start_trading.govspeak.erb (WARNING: contains interpolation)
Writing template: what_is_your_taxable_profit.govspeak.erb (WARNING: contains interpolation)
Deleting i18n YAML: part-year-profit-tax-credits.yml
Now insert `use_erb_templates_for_questions` at top of flow: part-year-profit-tax-credits.rb
These were not dealt with automatically by the conversion script.
chrisroos
force-pushed
the
convert-part-year-profit-tax-credits-to-use-erb-templates-for-questions
branch
from
ac2ac22 to
a26cb20
Compare
|
I've rebased on master and force pushed in preparation for merging. |
chrisroos
added a commit
that referenced
this pull request
Nov 19, 2015
…redits-to-use-erb-templates-for-questions Convert part-year-profit-tax-credits to use ERB templates for questions
chrisroos
deleted the
convert-part-year-profit-tax-credits-to-use-erb-templates-for-questions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this flow has no integration tests, but all the other unit & integration tests are passing, so I think all is well.