Combine data partials and shared partials #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
The smart_answer_flows/data_partials directory is a hangover from before the introduction of ERB templates. The smart_answer_flows/shared directory is where shared partials now live. This partial is only used by the register-a-birth and register-a-death Smart Answers so I've placed it in the shared/births_and_deaths_registration directory. I've added the .govspeak extension so that it's name is consistent with the other partials in this shared directory.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
register-a-birth \
lib/smart_answer_flows/shared/births_and_deaths_registration/_button.govspeak.erb
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
register-a-death \
lib/smart_answer_flows/shared/births_and_deaths_registration/_button.govspeak.erb
The smart_answer_flows/data_partials directory is a hangover from before the introduction of ERB templates. The smart_answer_flows/shared directory is where shared partials now live. This partial is used by 5 Smart Answers so I've placed it in the shared/ directory rather than a subdirectory of shared/. I've added the .govspeak extension so that it's name is consistent with the other partials in this shared directory.
Now that overseas_passports_embassies has moved.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
marriage-abroad \
lib/smart_answer_flows/shared/_overseas_passports_embassies.govspeak.erb
Now that overseas_passports_embassies has moved.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
overseas-passports \
lib/smart_answer_flows/shared/_overseas_passports_embassies.govspeak.erb
Now that overseas_passports_embassies has moved.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
register-a-birth \
lib/smart_answer_flows/shared/_overseas_passports_embassies.govspeak.erb
Now that overseas_passports_embassies has moved.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
register-a-death \
lib/smart_answer_flows/shared/_overseas_passports_embassies.govspeak.erb
Now that overseas_passports_embassies has moved.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
report-a-lost-or-stolen-passport \
lib/smart_answer_flows/shared/_overseas_passports_embassies.govspeak.erb
chrisroos
force-pushed
the
combine-data-partials-and-shared-partials
branch
from
a6f1d9a to
61b152b
Compare
|
I've rebased on master and force pushed in preparation for merging. |
chrisroos
added a commit
that referenced
this pull request
Nov 23, 2015
…ed-partials Combine data partials and shared partials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had shared partials in both the smart_answer_flows/data_partials/ and smart_answer_flows/shared/ directories, which was confusing.
The smart_answer_flows/data_partials/ directory is a hangover from the days before ERB templates and all partials should now live in the smart_answer_flows/shared/ directory.