Remove predicate functionality #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisroos
force-pushed
the
remove-predicate-functionality
branch
from
e2ac81e to
8b70366
Compare
|
I've run all the regression tests in this branch and am happy that I've not broken anything. There may be other things that can also be removed but I think this is good enough to get merged to master. |
So that the tests use `next_node` with a block instead of `next_node_if` unless they're specifically testing `next_node_if`. This is in preparation for removing the predicate code (`next_node_if` and friends).
The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code. I've retained the ability to call `next_node :next_node_name` by setting `@default_next_node_function` to a `proc` that returns the `:next_node_name`. This replicates the behaviour of calling `next_node` with a block directly.
We're no longer using `next_node_if` anywhere which means that `next_node_function_chain` will always be an empty array. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
Searching the project revealed that this isn't used anywhere. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
Required because of the removal of `responded_with_commonwealth_country?` from registrations_data_query.rb.
Required because of the removal of `responded_with_commonwealth_country?` from registrations_data_query.rb.
Required because of the removal of `responded_with_commonwealth_country?` from registrations_data_query.rb.
Along with the associated `Predicate::ResponseIsOneOf` class and tests. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
Along with the associated `Predicate::ResponseHasAllOf` class and tests. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
A search of the application reveals that this isn't being used anywhere.
Along with the associated `Predicate::RespondedWith` class and tests. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
Along with the associated `Predicate::VariableMatches` class and tests. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
And associated tests. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
A search of the project reveals that this is no longer being used anywhere. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
And associated tests. A search of the project reveals that this is no longer being used anywhere. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
A search of the project reveals that this is no longer being used anywhere. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
This is no longer necessary because `@predicates` is never set to anything other than an empty hash.
This is no longer necessary because `@predicates` is never set to anything other than an empty hash.
As `@next_node_function_chain` is no longer set to anything other than an empty array.
And the associated tests. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
And the associated tests. The use of predicates to define next node rules was deprecated a while back and we're now in the process of removing this predicate code.
chrisroos
force-pushed
the
remove-predicate-functionality
branch
from
8b70366 to
91f9275
Compare
|
I've rebased and force pushed in preparation for merging. |
chrisroos
added a commit
that referenced
this pull request
Nov 25, 2015
Remove predicate functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deprecated the use of the predicate logic a while back. This branch removes all the unused predicate logic code.
Expected user-facing changes