Revert PR #2265 #2273
Merged
Revert PR #2265 #2273
+3
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We revert PR #2265 because it turns out that there is a issue with how the
GOVUK.MultivariateTestcommunicates with theGOVUK.GoogleAnalyticsUniversalTrackerto set dimensions. The test sends 4 arguments: the dimension, the name of the test, the name of the cohort chosen, and the scope in which to set the dimension (see: https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/multivariate-test.js#L78-L83 for the call-site and https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/analytics/analytics.js#L53 for the abstraction that passes it to the actual tracker). The universal tracker only accepts 2 arguments: the dimension and the value to set for that dimension (see: https://github.com/alphagov/govuk_frontend_toolkit/blob/master/javascripts/govuk/analytics/google-analytics-universal-tracker.js#L138-L140) - the classic tracker, now removed, used to take all 4 arguments, but this is no longer how GA universal works.This means our GA tracking doesn't get any information about which cohort each user is in, so we can't interpret any data about which change has the best affect on our goals.
This reverts commit 1be8cce, reversing
changes made to 491aa07.