Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace appointment booking link (Marriage abroad Moldova) #2327

Merged
merged 2 commits into from
Mar 21, 2016

Conversation

ikennaokpala
Copy link
Contributor

@ikennaokpala ikennaokpala changed the title Replace the appointment booking (Marriage abroad MOLDOVA) Replace appointment booking link (Marriage abroad MOLDOVA) Mar 2, 2016
@floehopper
Copy link
Contributor

Note that CI build #4238 for this branch was hanging so I cancelled it and manually triggered a new build.

@ikennaokpala
Copy link
Contributor Author

@floehopper thanks for rebuilding the branch.

@ikennaokpala ikennaokpala force-pushed the marriage-abroad-moldova branch 2 times, most recently from cb6f274 to ce778a1 Compare March 18, 2016 12:46
@erkde
Copy link
Contributor

erkde commented Mar 20, 2016

It would be good if we could use correct capitalisation for country names in PR titles, descriptions as well as git commit notes.

Also, some of the commit notes wrap when I view them in github, which might be an indicator they are going over 72 characters in length.

@erkde erkde changed the title Replace appointment booking link (Marriage abroad MOLDOVA) Replace appointment booking link (Marriage abroad Moldova) Mar 20, 2016
@erkde erkde self-assigned this Mar 20, 2016
@ikennaokpala
Copy link
Contributor Author

@erikse will be looking at that

@ikennaokpala ikennaokpala force-pushed the marriage-abroad-moldova branch from acf2726 to 06e2981 Compare March 21, 2016 17:55
Ikenna Okpala added 2 commits March 21, 2016 18:11
This commit replaces the appointment booking link for Moldova with the address
of the British embassy in Chisinau, Moldova. This is a content change requested by the
content team.
@ikennaokpala ikennaokpala force-pushed the marriage-abroad-moldova branch from 06e2981 to 05d1b8f Compare March 21, 2016 18:13
@ikennaokpala
Copy link
Contributor Author

@erikse I have squashed this and rebased with master

@erkde
Copy link
Contributor

erkde commented Mar 21, 2016

Thanks for amending @ikennaokpala looks good to merge

@erkde erkde added the LGTM label Mar 21, 2016
ikennaokpala added a commit that referenced this pull request Mar 21, 2016
Replace appointment booking link (Marriage abroad Moldova)
@ikennaokpala ikennaokpala merged commit 08ff605 into master Mar 21, 2016
@ikennaokpala ikennaokpala deleted the marriage-abroad-moldova branch March 21, 2016 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants