Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to student finance forms #2335

Merged
merged 3 commits into from
Mar 11, 2016
Merged

Correction to student finance forms #2335

merged 3 commits into from
Mar 11, 2016

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Mar 7, 2016

Pivotal story: https://www.pivotaltracker.com/n/projects/503131/stories/114789765

Corrects tax information outcome for the student finance forms smart answer.

Fact check

https://smart-answers-pr-2335.herokuapp.com/student-finance-forms
https://smart-answers-pr-2335.herokuapp.com/student-finance-forms/y/uk-full-time/income-details/year-1617

Expected changes

URL on gov.uk

  • Remove copy "(eg a Maintenance Grant)" from first sentence on page
  • Update the year values in the second bullet from "2015 to 2016" to "2016 to 2017"

Before

screen shot 2016-03-07 at 9 38 52 am

After

screen shot 2016-03-07 at 9 39 13 am

Note: this PR supersedes #2332

@erkde erkde changed the title Sff update outcome Correction to student finance forms Mar 7, 2016
stwalsh and others added 3 commits March 11, 2016 10:37
It mentioned grants when it shouldn't and needed a couple of years updating.

https://www.pivotaltracker.com/n/projects/503131/stories/114789765
https://govuk.zendesk.com/tickets/1269679

 Changes to be committed:
	modified:   lib/smart_answer_flows/student-finance-forms/outcomes/outcome_parent_partner_1617.govspeak.erb
@erkde erkde force-pushed the sff_update_outcome branch from a483524 to 0165fe8 Compare March 11, 2016 10:37
@erkde
Copy link
Contributor Author

erkde commented Mar 11, 2016

This has been approved by fact check, and have just rebased with master and force pushed

erkde pushed a commit that referenced this pull request Mar 11, 2016
Correction to student finance forms
@erkde erkde merged commit e63e427 into master Mar 11, 2016
@erkde erkde deleted the sff_update_outcome branch March 11, 2016 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants