Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marriage abroad fee inconsistency #2350

Merged
merged 7 commits into from
Mar 15, 2016

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Mar 10, 2016

Pivotal Ticket: https://www.pivotaltracker.com/story/show/109438906

This PR is the first part of a change to the consular fees shown to users of the marriage abroad smart answer. It brings South Korea, Finland and Lebanon inline with existing values for services "Affirmation for marriage", "Affidavit for marriage" and "Affirmation for freedom to marry in English" which should all be £55 as presenting shown for all other countries that offer them.

Fact check

https://smart-answers-pr-2350.herokuapp.com/marriage-abroad

Expected changes

URL on gov.uk

  • Update fee for "Affidavit for marriage" to £55

Before

screen shot 2016-03-10 at 1 11 33 pm

After

screen shot 2016-03-10 at 1 11 45 pm

URL on gov.uk

  • Update fee for 'Affirmation for marriage" to £55

Before

screen shot 2016-03-10 at 1 14 40 pm

After

screen shot 2016-03-10 at 1 14 50 pm

URL on gov.uk

  • Update fee for "Affirmation for freedom to marry in English" to £55

Before

screen shot 2016-03-10 at 1 17 10 pm

After

screen shot 2016-03-10 at 1 17 15 pm

Note: this PR is first of several that supersedes #2168

@erkde erkde force-pushed the fix_marriage_abroad_fee_inconsistancy branch from 6f93d7c to 9921409 Compare March 10, 2016 15:36
@chrisroos chrisroos self-assigned this Mar 15, 2016
@chrisroos
Copy link
Contributor

This looks great to me, @erikse.

erkde added 7 commits March 15, 2016 07:50
The FCO has confirmed that an affidavit for marriage should be £55 in 
all countries, so this commit removes the existing variance for South
Korea where the fee has been shown as £65.
    
The FCO has also confirmed that an affirmation for marriage should be 
£55 in all countries, so this commit removes the existing variance for 
Finland where the fee has been shown as £65.
The FCO has clarified that any affirmation to marry should be £55 and 
variances such as this one ending in “in English” may need be replaced 
by the standard ‘Affirmation for marriage’.

This commit address the first issue, bringing the fee inline with all
other outcomes showing ‘Affirmation for freedom to marry in English’ 
and will allow us to now consolidate all fees in one partial.

Hopefully, having all the fees in one partial will allow us to address
the second issue, and allow further consolidation of consular fees and
eliminate unnecessary variances from appearing in marriage abroad
outcomes.
@erkde erkde force-pushed the fix_marriage_abroad_fee_inconsistancy branch from 9921409 to 125d5d6 Compare March 15, 2016 07:50
@erkde
Copy link
Contributor Author

erkde commented Mar 15, 2016

Thanks @chrisroos - have just rebased this with master in preparation for merging.

erkde pushed a commit that referenced this pull request Mar 15, 2016
…istancy

Fix marriage abroad fee inconsistancy
@erkde erkde merged commit 8bbe331 into master Mar 15, 2016
@erkde erkde deleted the fix_marriage_abroad_fee_inconsistancy branch March 15, 2016 07:54
@erkde erkde changed the title Fix marriage abroad fee inconsistancy Fix marriage abroad fee inconsistency Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants