Fix marriage-abroad test data #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming the test artefacts are still correct, this looks good to me 👍 |
This must've been added, and then removed, in the past as it still appears in the marriage abroad responses-and-expected-results data and outcomes for Slovenia appear in the regression tests artefacts.
I noticed these were out of date when doing some other work on
marriage-abroad.
I regenerated them with:
$ rails r script/generate-responses-and-expected-results-for-smart-answer.rb \
marriage-abroad
The regression tests for marriage-abroad are passing so I've updated the
checksum data.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
marriage-abroad
chrisroos
force-pushed
the
fix-marriage-abroad-test-data
branch
from
a2eb953 to
b034aff
Compare
|
Thanks @floehopper. I've updated the PR description to state that the marriage-abroad regression tests are continuing to pass. I've rebased and force pushed in preparation for merging. |
chrisroos
added a commit
that referenced
this pull request
Mar 15, 2016
Fix marriage-abroad test data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the responses-and-expected-results.yml file was no longer in sync with the questions-and-responses.yml.
This branch updates them so that they're back in sync.
The marriage-abroad regression tests continue to pass after these changes.