Remove regression test checksum file for part-year-profit-tax-credits flow #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flow uses a newer style of testing and so doesn't have a regression test associated with it. A flow only has a regression test if it has a `*-responses-and-expected-results.yml` file associated with it [1] and this flow does not have such a file. I believe this checksum file was accidentally added in this commit [2]. [1]: https://github.com/alphagov/smart-answers/blob/aabf580f3fbf53d6cdd4475380cb197d6dcacaea/lib/smart_answer_test_helper.rb#L10-L12 [2]: e757b61
|
The commit link in the description is broken for me |
|
Other than the broken link the description, seems ok |
|
@erikse: Thanks. I've just fixed the link. |
|
I'm about to rebase this against master and force-push in preparation for merging. |
|
No rebase needed. Merging. |
floehopper
added a commit
that referenced
this pull request
Mar 14, 2016
…edits-regression-test-checksums Remove regression test checksum file for part-year-profit-tax-credits flow
floehopper
deleted the
remove-part-year-profit-tax-credits-regression-test-checksums
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary regression test checksum file.
This flow uses a newer style of testing and so doesn't have a regression test associated with it.
A flow only has a regression test if it has a
*-responses-and-expected-results.ymlfile associated with it and this flow does not have such a file.I believe this checksum file was accidentally added in this commit.
Expected changes
None