Remove incorrect permitted next node from check-uk-visa #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch @floehopper. I think our Rubocop config wants trailing commas, which would reduce the diff by a line, otherwise looks good |
|
@erikse: Thanks. Rubocop wasn't failing, but I've added the trailing comma anyway in this fixup commit. |
|
I'm about to rebase this against master and force-push in preparation for merging. |
The `outcome_visit_waiver` is not a valid return value for the `next_node` block for this question. I came across this while double-checking that the mechanism for automatic detection of permitted next nodes was working correctly. The fact that this had managed to get out of sync highlights the duplication inherent in the current implementation and encourages me that the automatic detection mechanism will be an improvement.
floehopper
force-pushed
the
remove-incorrect-permitted-next-node-from-check-uk-visa
branch
from
d200a2b to
ce18edb
Compare
floehopper
added a commit
that referenced
this pull request
Mar 14, 2016
…t-node-from-check-uk-visa Remove incorrect permitted next node from check-uk-visa
floehopper
deleted the
remove-incorrect-permitted-next-node-from-check-uk-visa
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
outcome_visit_waiveris not a valid return value for thenext_nodeblock for this question.I came across this while double-checking that the mechanism for automatic detection of permitted next nodes was working correctly. The fact that this had managed to get out of sync highlights the duplication inherent in the current implementation and encourages me that the automatic detection mechanism will be an improvement.
Expected changes
None