Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embassy Address and Appointment Link changes for Kyrgyzstan and Kazakhstan #2363

Merged
merged 3 commits into from
Mar 21, 2016

Conversation

ikennaokpala
Copy link
Contributor

PT Stories:

Kyrgyzstan: https://www.pivotaltracker.com/n/projects/1270592/stories/115618321
Kazakhstan: https://www.pivotaltracker.com/n/projects/1270592/stories/115618165

  • Change Embassy location Kyrgyzstan & Kazakhstan

Factcheck for Kyrgyzstan

Expected changes

  • URL on Gov.UK
  • Change to City to Almaty to Bishkek and appointment booking link

Before

screen shot 2016-03-14 at 17 11 23

After

screen shot 2016-03-14 at 17 11 40

Factcheck for Kazakhstan

Expected changes

  • URL on Gov.UK
  • Change to City to Almaty to Astana and appointment booking link

Before

screen shot 2016-03-14 at 17 10 26

After

screen shot 2016-03-14 at 17 10 35

@ikennaokpala
Copy link
Contributor Author

@erikse @pmanrubia factcheck has comethrough kindly review

@ikennaokpala ikennaokpala force-pushed the marriage-abroad-kyrgyzstan-kazakhstan branch from 47690e7 to 8fb4269 Compare March 18, 2016 12:43
@erkde
Copy link
Contributor

erkde commented Mar 20, 2016

@ikennaokpala - with the screenshots, one thing I've been trying to do is only highlight the text that is changed, so I don't have read through content that doesn't

@erkde
Copy link
Contributor

erkde commented Mar 20, 2016

@ikennaokpala - is there an update to the marriage abroad checksums file missing in this PR?

@erkde erkde self-assigned this Mar 20, 2016
@ikennaokpala
Copy link
Contributor Author

Will regenerate it and push @erikse

@ikennaokpala ikennaokpala force-pushed the marriage-abroad-kyrgyzstan-kazakhstan branch from 8fb4269 to 71e7890 Compare March 21, 2016 10:07
@erkde
Copy link
Contributor

erkde commented Mar 21, 2016

Other than than the commit notes in the first two commits wrapping and probably being over 72 characters, this looks good to rebase, and merge

@erkde erkde added the LGTM label Mar 21, 2016
@ikennaokpala ikennaokpala force-pushed the marriage-abroad-kyrgyzstan-kazakhstan branch from 96dda1c to 7df1266 Compare March 21, 2016 17:09
Ikenna Okpala added 3 commits March 21, 2016 17:22
This commit changes the appointment booking location link and location city for
kyrgyzstan and kazakhstan. This commit was made as one to avoid any merge conflicts,
and also given that they both shared the same location previously.
This commit contain regression artefact changes that reflect that changes made to the
marriage abroad details for Kyrgyzstan and Kazakhstan
@ikennaokpala ikennaokpala force-pushed the marriage-abroad-kyrgyzstan-kazakhstan branch from 7df1266 to 729f586 Compare March 21, 2016 17:24
ikennaokpala added a commit that referenced this pull request Mar 21, 2016
…akhstan

Embassy Address and Appointment Link changes for Kyrgyzstan and Kazakhstan
@ikennaokpala ikennaokpala merged commit 82db1c4 into master Mar 21, 2016
@ikennaokpala ikennaokpala deleted the marriage-abroad-kyrgyzstan-kazakhstan branch March 21, 2016 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants