Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor overseas passports flow updates" #2375

Closed

Conversation

erkde
Copy link
Contributor

@erkde erkde commented Mar 17, 2016

Since merging this branch, the regression test are showing diffs in the artefacts. As there appears to be a number of issues, we should probably revert so we can resolve without effecting other work.

Reverts #2367

@erkde
Copy link
Contributor Author

erkde commented Mar 17, 2016

I think given the size of this revert, I'll close this and I'll prepare a PR with a fix to flow, the cause seems to a poor rebase with master prior to the merge with master that included a small change to smart answer DSL.

@erkde erkde closed this Mar 17, 2016
@chrisroos
Copy link
Contributor

In general, I think we should prefer fixing problems by improving the code rather than by reverting changes, so I think closing this and fixing the problem in #2376 was the right thing to do.

Out of interest, was the problem caused by GitHub's automatic merging, or was it simply due to a complicated rebase/merge?

@floehopper
Copy link
Contributor

@chrisroos: I believe the problems were introduced when the branch was manually rebased against master in preparation for merging.

@chrisroos chrisroos deleted the revert-2367-refactor_overseas_passports_flow_updates branch March 25, 2016 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants