Remove marriage-abroad outcome_cp_consular precalculate blocks #2382
+30
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm refactoring marriage-abroad so that the `MarriageAbroadCalculator` contains everything necessary to render the outcomes. Adding this method will allow me to remove the `:institution_name` in a subsequent commit. I've added the `civil_partnership` prefix to the new method name as the value is only displayed in a civil partnership outcome.
And remove the now unused `:institution_name` precalculate block.
The marriage-abroad regression tests are passing so I'm updating the
checksum data accordingly.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
marriage-abroad
|
This looks good to me. |
|
Thanks for reviewing, @floehopper. This is already up to date with master so I'm going to merge it. |
chrisroos
added a commit
that referenced
this pull request
Mar 19, 2016
…-cp-consular-precalculate-blocks Remove marriage-abroad outcome_cp_consular precalculate blocks
chrisroos
deleted the
remove-marriage-abroad-outcome-cp-consular-precalculate-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm continuing to refactor marriage-abroad. This branch removes the
precalculateblocks from outcome_cp_consular by adding logic to theMarriageAbroadCalculator.