Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OverseasPassportsCalculator to regression test checksums #2383

Conversation

floehopper
Copy link
Contributor

Description

This should've been added as part of #2367, so that changes to the calculator cause the regression tests to run.

I did this by running the following command:

$ rails r script/generate-checksums-for-smart-answer.rb overseas-passports \ 
  lib/smart_answer/calculators/overseas_passports_calculator.rb

External changes

None.

@erkde erkde self-assigned this Mar 19, 2016
@erkde
Copy link
Contributor

erkde commented Mar 19, 2016

Well spotted, thanks for adding this @floehopper

@erkde erkde added the LGTM label Mar 19, 2016
@floehopper
Copy link
Contributor Author

Rebasing against master and force-pushing in preparation for merging.

@floehopper floehopper force-pushed the add-overseas-passports-calculator-to-regression-test-checksums branch from c1113dd to 9b33edc Compare March 21, 2016 12:12
floehopper added a commit that referenced this pull request Mar 21, 2016
…tor-to-regression-test-checksums

Add OverseasPassportsCalculator to regression test checksums
@floehopper floehopper merged commit 0763a64 into master Mar 21, 2016
@floehopper floehopper deleted the add-overseas-passports-calculator-to-regression-test-checksums branch March 21, 2016 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants