Remove unnecessary instance variable assignment in SmartAnswer::Question::Base #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to merge |
Instance variables are set to `nil` by default, so this assignment is unnecessary.
|
Rebasing against master and force-pushing in preparation for merging. |
floehopper
force-pushed
the
remove-unnecessary-instance-variable-assignment-in-question-base
branch
from
fad2908 to
bd462f6
Compare
floehopper
added a commit
that referenced
this pull request
Mar 21, 2016
…riable-assignment-in-question-base Remove unnecessary instance variable assignment in SmartAnswer::Question::Base
floehopper
deleted the
remove-unnecessary-instance-variable-assignment-in-question-base
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instance variables are set to
nilby default, so this assignment is unnecessary.External changes
None.