Remove marriage-abroad outcome path precalculate blocks #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're aiming toward having the `MarriageAbroadCalculator` be the only object required to render outcomes. Moving the logic of this `:uk_residence_outcome_path` precalculate block is the first step toward me being able to remove the block.
We're aiming toward having the `MarriageAbroadCalculator` be the only object required to render outcomes. Moving the logic of this `:ceremony_country_residence_outcome_path` precalculate block is the first step toward me being able to remove the block.
This was previously used in the `:uk_residence_outcome_path` and `:ceremony_country_residence_outcome_path` precalculate blocks. It's no longer required now that the logic of those precalculate blocks has been moved to the `MarriageAbroadCalculator`.
Using this `MarriageAbroadCalculator` method will allow me to remove the `:uk_residence_outcome_path` precalculate block.
This is no longer required as I'm using `MarriageAbroadCalculator#outcome_path_when_resident_in_uk` in the outcomes.
Using this `MarriageAbroadCalculator` method will allow me to remove the `:ceremony_country_residence_outcome_path` precalculate block.
This is no longer required as I'm using `MarriageAbroadCalculator#outcome_path_when_resident_in_ceremony_country` in the outcomes.
The marriage-abroad regression tests are passing.
Updated using:
$ rails r script/generate-checksums-for-smart-answer.rb \
marriage-abroad
chrisroos
added a commit
that referenced
this pull request
Mar 19, 2016
…-path-precalculate-blocks Remove marriage-abroad outcome path precalculate blocks
chrisroos
deleted the
remove-marriage-abroad-outcome-path-precalculate-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes PR #2381. See that PR for discussion.
I'm continuing to refactor marriage-abroad. This branch removes the
precalculateblocks from outcome_os_kuwait, outcome_spain and outcome_consular_cni_os_residing_in_third_country by moving logic to theMarriageAbroadCalculator.