Consistently use question mark suffix for question node keys in docs #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,5 +73,5 @@ Occurs if the `next_node` blocks returns a value that isn't defined as a questio | |||
| next_node do | |||
| outcome :red | |||
| end | |||
| outcome :green | |||
| outcome :green? | |||
There was a problem hiding this comment.
I don't think this one should've been changed.
There was a problem hiding this comment.
Good catch. I've changed it to outcome :blue so that it's less confusing. Fix-up commit: 87af37e.
|
Aside from one change that doesn't look right, this all looks good to me. |
|
Rebasing to incorporate fix-up commit, then rebasing against master, resolving conflicts and force-pushing in preparation for merge. |
floehopper
force-pushed
the
fix-question-node-keys-in-docs
branch
from
87af37e to
e9f93ec
Compare
floehopper
added a commit
that referenced
this pull request
Mar 22, 2016
Consistently use question mark suffix for question node keys in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation change only.