Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace standard visitor with short-term study (Content and Link) For Taiwan #2398

Merged
merged 3 commits into from
Mar 24, 2016
Merged

Replace standard visitor with short-term study (Content and Link) For Taiwan #2398

merged 3 commits into from
Mar 24, 2016

Conversation

ikennaokpala
Copy link
Contributor

@ikennaokpala ikennaokpala changed the title Changed visa link Replace standard visitor with short-term study Mar 22, 2016
@ikennaokpala ikennaokpala mentioned this pull request Mar 22, 2016
Closed
@ikennaokpala ikennaokpala changed the title Replace standard visitor with short-term study Replace standard visitor with short-term study (Content and Link) Mar 22, 2016
@ikennaokpala ikennaokpala force-pushed the change-study-visa-link branch from 0b240c9 to fbac5c6 Compare March 22, 2016 17:12
@keithiopia
Copy link
Contributor

This doesn't need a factcheck with the department, and the preview looks good to me.
GTG.

@ikennaokpala
Copy link
Contributor Author

@keithiopia Thanks for letting us know will move on with code review..

@floehopper floehopper self-assigned this Mar 24, 2016
@floehopper
Copy link
Contributor

Minor: I think the commit note subject line for the first commit should mention "Taiwan", because as far as I can see that's the only outcome that is changing. It should be fine to amend the commit note for that commit - @keithiopia will remain the "author" of the commit and you will be the "committer".

@floehopper
Copy link
Contributor

Minor: I think the PR title should mention "Taiwan" and it could probably be less detailed e.g. "Content changes for Taiwan outcome in Check UK Visa". This seems quite important, because the PR description doesn't really mention Taiwan either.

@ikennaokpala ikennaokpala changed the title Replace standard visitor with short-term study (Content and Link) Replace standard visitor with short-term study (Content and Link) For Taiwan Mar 24, 2016
@floehopper
Copy link
Contributor

Very minor: The browser developer tools in the screenshots are a bit distracting.

@keithiopia
Changed visa link for Taiwan
e94ba3e 
Changed visa needed from standard visitor to short-term study.
Request was in https://govuk.zendesk.com/agent/tickets/1287220
@floehopper
Copy link
Contributor

Other than my minor comments, this looks good to me. 👍

@ikennaokpala ikennaokpala force-pushed the change-study-visa-link branch from fbac5c6 to 8ae29b4 Compare March 24, 2016 11:39
@ikennaokpala ikennaokpala merged commit 0fd1f90 into master Mar 24, 2016
@ikennaokpala ikennaokpala deleted the change-study-visa-link branch March 24, 2016 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@floehopper floehopper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikennaokpala @keithiopia @floehopper