Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing link to a referenced commit #2417

Merged
merged 2 commits into from
Mar 30, 2016
Merged

Add a missing link to a referenced commit #2417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f09332
Add a missing link to a referenced commit
leenagupte Mar 30, 2016
f61759f
Fix syntax error in Creating a new flow code example
leenagupte Mar 30, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/creating-a-new-smart-answer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module SmartAnswer
value_question :question_1? do
next_node do
outcome :outcome_1
end:
end
end

outcome :outcome_1
Expand Down
2 changes: 1 addition & 1 deletion doc/refactoring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ These concerns should really be split. Routing belongs in the flow, policy/calcu

We've refactored a small number of these Smart Answers and have a rough set of steps that we follow:

* Remove unused code from the flow, e.g. unused `save_input_as`, `precalculate` or `calculate` blocks. See commit fe4014d7c007108f3daa07f1c5dd749f5de683a0 for an example.
* Remove unused code from the flow, e.g. unused `save_input_as`, `precalculate` or `calculate` blocks. See commit [fe4014d7c007108f3daa07f1c5dd749f5de683a0](https://github.com/alphagov/smart-answers/commit/fe4014d7c007108f3daa07f1c5dd749f5de683a0) for an example.

* Include `ActiveModel::Model` in the calculator so that it's easy to instantiate it with a number of attributes set. See commit [f78671a062339ae97abb5cb267b55536233316c9](https://github.com/alphagov/smart-answers/commit/f78671a062339ae97abb5cb267b55536233316c9) for an example.

Expand Down