Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of factual error in Check UK Visa #2445

Merged
merged 3 commits into from
Apr 7, 2016
Merged

Removal of factual error in Check UK Visa #2445

merged 3 commits into from
Apr 7, 2016

Conversation

ikennaokpala
Copy link
Contributor

Trello Story: https://trello.com/c/SQyWbeEv/87-asap-check-if-you-need-a-uk-visa-content-change

Factcheck here

Expected changes

*URL on GOV.UK

Before

screen shot 2016-04-07 at 14 12 15

After

screen shot 2016-04-07 at 17 16 01

@ikennaokpala
Copy link
Contributor Author

This supersedes #2430

@ikennaokpala ikennaokpala mentioned this pull request Apr 7, 2016
Closed
@ikennaokpala
Copy link
Contributor Author

@Lilboyce has approved the factcheck.. ready for code review @leenagupte

@pmanrubia pmanrubia self-assigned this Apr 7, 2016
@pmanrubia
Copy link
Contributor

I would apply the following changes:

  • Remove the author from the title. You might add a link to the superseded PR in the description.
  • Content changes feels a bit generic. Can you think of a different title that includes the flow name: check-uk-visa?
  • The factcheck link appears twice in the description

@pmanrubia
Copy link
Contributor

Before and after images are the same. You might have picked up the same one twice?

@pmanrubia
Copy link
Contributor

Would you mind updating the commit title? content change is a bit generic to me. The committer won't be lost if you only rename the title.

@ikennaokpala ikennaokpala changed the title Content changes from Lil Boyce on Removal of factual error Removal of factual error in Check UK Visa Apr 7, 2016
Lilboyce and others added 3 commits April 7, 2016 17:18
@ikennaokpala ikennaokpala force-pushed the changes-fron-lilboyce branch from b2c2749 to 3ac8504 Compare April 7, 2016 16:19
@ikennaokpala
Copy link
Contributor Author

@pmanrubia Thanks for reviewing this.. I have made changes as per your recommendations.

@pmanrubia
Copy link
Contributor

Thank you @ikennaokpala. Great job 👍

@pmanrubia pmanrubia added the LGTM label Apr 7, 2016
@ikennaokpala ikennaokpala merged commit 8b8b519 into master Apr 7, 2016
@ikennaokpala ikennaokpala deleted the changes-fron-lilboyce branch April 7, 2016 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmanrubia pmanrubia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikennaokpala @pmanrubia @Lilboyce