Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third round of content changes to State Pension via Partner #2446

Merged
merged 1 commit into from
Apr 8, 2016

Conversation

ikennaokpala
Copy link
Contributor

Trello Story: https://trello.com/c/nPSEUm5P/99-asap-your-partner-s-national-insurance-record-and-your-state-pension

These changes were made upon request from the content team

it contains the regenerated artefacts and checksum data files

Factcheck here

Expected changes

*URL on GOV.UK

Before

screen shot 2016-04-07 at 13 58 50

After

screen shot 2016-04-07 at 13 58 23

These changes were made upon request from the content team

it contains the regenerated artefacts and checksum data files
@ikennaokpala
Copy link
Contributor Author

This PR is an update on content from #2432

@pmanrubia
Copy link
Contributor

  • I would remove round 3 and I would add links to the previous 2 PRs in the description. Round 3 is not adding much value if you don't have access to the previous 2 PRs. Not sure either about including the round number as the calculator is being updated very often.
  • If you want to stick to it, I would add it to the end and I would use lowercase: Content changes to State Pension via Partner (round 3).
  • The fact check link has been included twice.

@pmanrubia pmanrubia self-assigned this Apr 7, 2016
@pmanrubia
Copy link
Contributor

What are your thoughts about decreasing the commits granularity to:

  • Update age_dependent_pension_outcome in state-pension-through-partner
  • Update married_woman_no_state_pension_outcome in state-pension-through-partner
  • Update widow_and_old_pension_outcome in state-pension-through-partner
  • Update artefacts for state-pension-through-partner
  • Update checksums for state-pension-through-partner

@ikennaokpala ikennaokpala changed the title ROUND 3 of Content changes to State Pension via Partner Content changes to State Pension via Partner Apr 7, 2016
@ikennaokpala ikennaokpala changed the title Content changes to State Pension via Partner Third round of content changes to State Pension via Partner Apr 7, 2016
@ikennaokpala
Copy link
Contributor Author

@pmanrubia I have made the changes to this PR as per your review

@pmanrubia pmanrubia merged commit a1af800 into master Apr 8, 2016
@chrisroos chrisroos deleted the partners-national-insurance-record branch May 27, 2016 05:09
floehopper added a commit that referenced this pull request Jun 27, 2016
I believe this Smart Answer was updated for 6th April, 2016 in #2432 & #2446.
And in any case it is now well after 6th April, 2016, so this comment doesn't
seem to be helping!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants