Content changes for opposite and same sex outcomes where user lives in UK or SA #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikennaokpala
force-pushed
the
marriage-outcomes-uk-sa
branch
from
67beb52 to
8b7de14
Compare
ikennaokpala
force-pushed
the
marriage-outcomes-uk-sa
branch
8 times, most recently
from
cd2d8b8 to
7c41882
Compare
ikennaokpala
force-pushed
the
marriage-outcomes-uk-sa
branch
from
7c41882 to
67e7d4c
Compare
| calculator.resident_of_uk? || | ||
| calculator.resident_of_ceremony_country? || | ||
| calculator.resident_of_third_country? | ||
| ) |
There was a problem hiding this comment.
Is this check needed? A user must always be either a resident of the UK, a resident of South Africa or a resident of another country, so this check will always be truthy.
There was a problem hiding this comment.
@leenagupte this check initially started with like with the require for user either a uk resident or resident of ceremony_country
elsif calculator.ceremony_country == 'south-africa' &&
(
calculator.resident_of_uk? ||
calculator.resident_of_ceremony_country?
)
After factcheck FCO made another requirement for third_country
I have decided to keep it this way for explicit reasons, make it a bit more obvious the 3 potential areas affected by this node.
There was a problem hiding this comment.
I agree with @leenagupte about removing this check. I think it makes the code more complex for no real benefit.
|
Apart from my comments, LGTM. |
ikennaokpala
force-pushed
the
marriage-outcomes-uk-sa
branch
3 times, most recently
from
79229df to
580a1c7
Compare
added 3 commits
April 26, 2016 11:58
These changes affect All opposite and same sex outcomes where user lives in the United Kingdom or in South Africa. These changes were requested by the content team. Affecting only these URLs/pages: UK citizen living in the UK /marriage-abroad/y/south-africa/uk/partner_british/opposite_sex /marriage-abroad/y/south-africa/uk/partner_british/same_sex /marriage-abroad/y/south-africa/uk/partner_local/opposite_sex /marriage-abroad/y/south-africa/uk/partner_local/same_sex /marriage-abroad/y/south-africa/uk/partner_other/opposite_sex /marriage-abroad/y/south-africa/uk/partner_other/same_sex UK citizen in ceremony country /marriage-abroad/y/south-africa/ceremony_country/partner_british/opposite_sex /marriage-abroad/y/south-africa/ceremony_country/partner_british/same_sex /marriage-abroad/y/south-africa/ceremony_country/partner_local/opposite_sex /marriage-abroad/y/south-africa/ceremony_country/partner_local/same_sex /marriage-abroad/y/south-africa/ceremony_country/partner_other/opposite_sex /marriage-abroad/y/south-africa/ceremony_country/partner_other/same_sex UK citizen in third country /marriage-abroad/y/south-africa/third_country/partner_british/opposite_sex /marriage-abroad/y/south-africa/third_country/partner_british/same_sex /marriage-abroad/y/south-africa/third_country/partner_local/opposite_sex /marriage-abroad/y/south-africa/third_country/partner_local/same_sex /marriage-abroad/y/south-africa/third_country/partner_other/opposite_sex /marriage-abroad/y/south-africa/third_country/partner_other/same_sex Update marriage abroad test expectations. Add tests for marriage outcomes South Africa
ikennaokpala
force-pushed
the
marriage-outcomes-uk-sa
branch
from
580a1c7 to
a728525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Story: https://trello.com/c/SSdBWMvO/107-marriage-abroad-south-africa
Factcheck
Expected changes
Before
After
Factcheck
Expected changes
Before
After
Factcheck
Expected changes
Before
After
Factcheck
Expected changes
Before
After