Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for the 2014-2015 tax year to estimate self assessment penalties #2590

Merged

Conversation

leenagupte
Copy link
Contributor

@leenagupte leenagupte commented Jun 16, 2016

@pmanrubia pmanrubia self-assigned this Jun 23, 2016
@pmanrubia
Copy link
Contributor

Minor: What about renaming the commit title from estimate-self-assesment-penalties to self-assesment-penalties? I would also add that prefix to the end of the commit, as it seems to be less important than what the commit does. It is just adding some context to it.

Minor: I would squash e9d906d into dc555cf. It seems sensible to have them together if we follow a TDD approach.

@pmanrubia
Copy link
Contributor

@leenagupte good work. 👍
Just two minor comments for your consideration.

@leenagupte
Copy link
Contributor Author

leenagupte commented Jun 27, 2016

@pmanrubia The commit headings are named after the calculator slug estimate-self-assesment-penalties.

The idea was, that you would look at it and know exactly which flow (and it's associated bumf) had been updated.

@leenagupte
Copy link
Contributor Author

leenagupte commented Jun 27, 2016

@pmanrubia I can squash the commits if you want. Makes no difference to me.

Update: e9d906d and dc555cf have been squashed to form 718f241

@leenagupte leenagupte force-pushed the estimate-self-assessment-penalties-add-2014-15-tax-year branch from bb2c587 to 723b2c6 Compare June 27, 2016 14:57
The GOV.UK service for estimating the penalty for late submission of an Self
Assessment return or late payment of an Self Assessment bill is only set up for
returns for the following tax years:

6 April 2011 to 5 April 2012
6 April 2012 to 5 April 2013
6 April 2013 to 5 April 2014

Updated to also assess penalties for returns for the 2014/2015 tax year.
The deadline for April 2014 to April 2015 returns is 31st January 2016.

Added tax year 2014/2015 to the integration tests
Update the questions, responses and expected results for regression tests
@leenagupte leenagupte force-pushed the estimate-self-assessment-penalties-add-2014-15-tax-year branch from 723b2c6 to f14becc Compare July 12, 2016 10:39
@leenagupte
Copy link
Contributor Author

Passed Factcheck

@leenagupte leenagupte merged commit 9f0ae28 into master Jul 12, 2016
@leenagupte leenagupte deleted the estimate-self-assessment-penalties-add-2014-15-tax-year branch October 19, 2016 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants