Split marriage-abroad outcome for Poland #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
The current outcome template (outcome_opposite_sex_marriage_in_poland_when_residing_in_uk_or_poland) contains two logical outcomes: * One for residents of UK * One for residents of Poland The outcome body contains multiple `if/else` statements that, when combined, essentially results in one of two logical outcomes being displayed. Splitting these logical outcomes and moving the "routing logic" to the flow is more consistent with the majority of this Smart Answer. Note that there is some common content between these logical outcomes but there is more that's different so I still think it makes sense to split the template. This change will make it easier to split the outcome in a subsequent commit.
The new outcome template is a copy of outcome_opposite_sex_marriage_in_poland_when_residing_in_uk_or_poland. I'll remove the logic and content relating to residents outside of the UK in a subsequent commit.
I'll remove the logic and content for residents outside of Poland in a subsequent commit.
I've removed all the logic and content related to residents of Poland. This diff is best viewed using the `--ignore-all-space` option.
I've removed all the logic and content related to residents of the UK. This diff is best viewed using the `--ignore-all-space` option.
Updating as the marriage-abroad regression tests are passing.
chrisroos
force-pushed
the
split-marriage-abroad-outcome-for-poland
branch
from
1537f4a to
88282e7
Compare
|
I've rebased this branch on master and force pushed in preparation for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current outcome template (outcome_opposite_sex_marriage_in_poland_when_residing_in_uk_or_poland) contains two logical outcomes:
The outcome body contains multiple
if/elsestatements that, when combined,essentially results in one of two logical outcomes being displayed. Splitting
these logical outcomes and moving the "routing logic" to the flow is more
consistent with the majority of this Smart Answer. Note that there is some
common content between these logical outcomes but there is more that's
different so I still think it makes sense to split the template.