Convert next_node_calculation blocks into on_response blocks in benefit-cap-calculator #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, @floehopper! |
|
Rebasing against master and force-pushing in preparation for merging. |
This is part of an effort to move all flows towards a new style [1]. In the new style, `next_node_calculation` blocks are deprecated. This commit removes the only two remaining usages in production code (once other pending PRs have been merged). Note that I've chosen to update the regression test checksums in this commit, because all the regression tests are still passing i.e. this was just an internal refactoring; no external behaviour has changed. [1]: https://github.com/alphagov/smart-answers/blob/master/doc/refactoring.md
floehopper
force-pushed
the
remove-use-of-next-node-calculation-from-benefit-cap-calculator
branch
from
84fcb77 to
efa030a
Compare
floehopper
deleted the
remove-use-of-next-node-calculation-from-benefit-cap-calculator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trello card: https://trello.com/c/LP9tmz3N
This is part of an effort to move all flows towards a new style. In the new style,
next_node_calculationblocks are deprecated. This commit removes the only two remaining usages in production code (once other pending PRs have been merged).Note that I've chosen to update the regression test checksums in this commit, because all the regression tests are still passing i.e. this was just an internal refactoring; no external behaviour has changed.
External changes
None. This is just an internal refactoring.