Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Update for all Opposite Sex Marriages in Slovakia #2776

Conversation

ikennaokpala
Copy link
Contributor

@ikennaokpala ikennaokpala commented Oct 7, 2016

Trello card

Description

Affecting all opposite sex marriage outcomes for Slovakia.

Factcheck

Preview link
GOV.UK

Expected changes

  • Update with "Matrika" based content

Before

screen shot 2016-10-07 at 15 46 45

After

screen shot 2016-10-07 at 15 48 37

@ikennaokpala ikennaokpala force-pushed the marriage-abroad/content-changes-for-all-opposite-sex-slovakia branch from 35c90c9 to d19ffab Compare October 7, 2016 14:43
@ikennaokpala ikennaokpala added needs content review Waiting for a content designer to approve Ready for code review labels Oct 7, 2016
@leenagupte leenagupte self-assigned this Oct 17, 2016
This commit updates the content for opposite sex marriages in Slovakia.

This update includes the Matrika specific instructions, this has lead to the
removal of Slovakia from OS_MARRIAGE_VIA_LOCAL_AUTHORITIES
group.

So a new if operator node and outcome has been defined for Slovakia
This commit holds regenerated regression test artefacts for for all opposite
sex marriages in Slovakia.

These changes were made upon request from the, Content Team.

Already existing unit, regression and integration tests passed, giving
assurance that the aforementioned commit/changes have had no
(interfering) effect to other smart answers.
@ikennaokpala ikennaokpala force-pushed the marriage-abroad/content-changes-for-all-opposite-sex-slovakia branch from d19ffab to 6e8aaa8 Compare October 17, 2016 16:45
@leenagupte
Copy link
Contributor

👍

@leenagupte leenagupte added Waiting on factcheck and removed needs content review Waiting for a content designer to approve Ready for code review labels Oct 18, 2016
@sistephens
Copy link
Contributor

Ready for merge and deploy, thanks 👍

@ikennaokpala ikennaokpala merged commit 5240e8d into master Oct 18, 2016
@ikennaokpala
Copy link
Contributor Author

@sistephens thanks for letting us know..

@ikennaokpala ikennaokpala deleted the marriage-abroad/content-changes-for-all-opposite-sex-slovakia branch October 18, 2016 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants