Add 2015-2016 option and Remove 2011-2012 option from ESAP Smart Answer #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikennaokpala
changed the title
ikennaokpala
added
needs content review
|
LGTM @ikennaokpala |
ikennaokpala
changed the title
In preparation to add new years to the calculator, we add a test for the method that calculates the start of the year.
In preparation to add new years to the calculator, we add a test for the method that calculates `one year after start date for penalties`
Using a default value does not make sense from a policy perspective. If we don’t have a match for one of the selected years it is because we are not listing them correctly, and something need to be fixed. This update surfaced an issue with the test as it was assigning a symbol to the calculator (attribute tax_year), and the application is assigning a string.
Regression tests: we have not generated the questions and expected results using the script: `script/generate-responses-and-expected-results-for-smart-answer`. The reason is because not all combination of `which_year`, `when_submited` and `when_paid` make sense. So, to make it compliant with the rest of questions and expected responses I have manually extended the file: `test/data/estimate-self-assessment-penalties-responses-and-expected-results.yml` with the compatible options for year 2015-16
This commit shows the preparatory step of removing 2011-12 from the regression test configuration files. This removal triggers the renaming of 2011-12 to 2012-13 regression files. This also has similar change for 2012-13 to 2013-14. For 2014-2015 new file have been created. This commit doesn't show any changes to the first question (i.e estimate-self-assessment-penalties/y), This give assurance that this setup will form the basis for evaluating the removal of 2011-12 in later commits. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) effect to other smart answers.
This commit removes the 2011-2012 option for Estimate Self Assessment Penalties Smart Answer. Direct removal have been made to templates and flow (related test) files respectively. These changes have been made upon request from the Content Team. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) effect to other smart answers.
ikennaokpala
force-pushed
the
estimate-self-assessment-penalties/remove-2011-2012-cntd
branch
from
5dd0476 to
398881c
Compare
ikennaokpala
added
Passed factcheck
and removed
needs content review
ikennaokpala
deleted the
estimate-self-assessment-penalties/remove-2011-2012-cntd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2782
Trello card
Motivation
Having entered 2016-2017 tax year there is little need for the older tax years.
This PR seeks to disable the selection of 2011-2012 option on the Estimate your penalty for late Self Assessment tax returns and payments Smart Answer.
Factcheck 2011-2012
Preview link
GOV.UK
Expected changes
Before
After
Factcheck 2015-2016
Expected changes
Before
After