Update maternity paternity rates for 2017/18 and onwards #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikennaokpala
force-pushed
the
maternity-paternity-calculator/april-2016-rate-changes
branch
from
e9726b2 to
f0430d7
Compare
ikennaokpala
added
needs content review
chao-xian
reviewed
Jan 11, 2017
There was a problem hiding this comment.
This is more of a content issue that I spotted and nothing to do with your code changes, but we can (and probably should) fix this minor inconsistency while we're here: we refer to Statutory Adoption Pay and Statutory Paternity Pay in title case but we refer to statutory maternity pay in lower case. Do you mind clarifying with Content Team please whether these should all be Title Case or lower case please?
|
Just the really minor inconsistency commented above but otherwise code changes LGTM 👍 |
chao-xian
approved these changes
Jan 12, 2017
ikennaokpala
force-pushed
the
maternity-paternity-calculator/april-2016-rate-changes
branch
from
f0430d7 to
4f0ffba
Compare
ikennaokpala
added
Passed code review
and removed
needs content review
In preparation for the 6th April rates update, this commit replaces 2014/2015 dates with 2017/2018 dates. This is a straight swap & triggers this generation of new regression test artefacts for 2017/2018 and removal of 2014/2015. Before this I tried using both sets of dates but the tests took ages to run. I have decided to make this swap based on test run performance. I recognised that it appears somewhat confusing, the intent is to make clear the rate changes that will come after this. These sets the basis for evaluating the content changes in the commits to come, as the configuration.yml entry for maternity-paternity-calculator has been updated to a future date.. Based on the above, I have reviewed the changes to the regression test artefacts and they appear as expected. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) effect to other smart answers.
This commit updates the maternity paternity adoption rates for 2017/18 and for the foreseeable future. I have included the regression test artefacts within to show areas affected by these changes Based on the above, I have reviewed the changes to the regression test artefacts and they appear as expected. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) effect to other smart answers.
This commit updates the maternity paternity birth rates for 2017/18 and for the foreseeable future. I have included the regression test artefacts within to show areas affected by these changes Based on the above, I have reviewed the changes to the regression test artefacts and they appear as expected. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) effect to other smart answers.
This commit updates the maternity paternity standard rate for 2017/18 and for the foreseeable future. I have included the regression test artefacts within to show areas affected by these changes Based on the above, I have reviewed the changes to the regression test artefacts and they appear as expected. Already existing unit, regression and integration tests passed, giving assurance that the aforementioned commit/changes have had no (interfering) effect to other smart answers.
ikennaokpala
force-pushed
the
maternity-paternity-calculator/april-2016-rate-changes
branch
from
4f0ffba to
39515ee
Compare
ikennaokpala
deleted the
maternity-paternity-calculator/april-2016-rate-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Motivation
The maternity paternity calculator are going to change on 6th April 2017 as follows:
To prepare the public for the coming changes, the maternity paternity calculator smart answer needs to be updated to allow the public get access to new rates.
NB:
Used environment variable from this PR #2412, setting RATES_QUERY_DATE to 2018-04-05
Factcheck
Preview link
Expected changes
URL on GOV.UK
Before
After