Use 2 outcomes for Thailand in Marriage abroad #2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmanrubia
added
Ready for code review
needs content review
leenagupte
reviewed
Mar 14, 2017
| @@ -802,8 +802,6 @@ def self.translations | |||
| context "ceremony in thailand, resident in the UK, partner other" do | |||
There was a problem hiding this comment.
Really minor thing, but I would change the title of this test to reflect that we are only testing for "opposite sex" now and not residence, or partner's nationality.
leenagupte
requested changes
Mar 14, 2017
There was a problem hiding this comment.
@pmanrubia You need to regenerate the test artefacts in commit cf2395b. I'm expecting 18 artefact files to be deleted, and two new ones to be added. 😄
pmanrubia
force-pushed
the
marriage-abroad-2-outcomes-thailand
branch
2 times, most recently
from
81f5f61 to
894e2e7
Compare
|
@leenagupte this is embarrassing 😊 . I forgot to regenerate the artefacts. I have addressed your comments. Thank you for your review. |
pmanrubia
force-pushed
the
marriage-abroad-2-outcomes-thailand
branch
from
894e2e7 to
417e14e
Compare
leenagupte
approved these changes
Mar 14, 2017
|
👍 LGTM |
leenagupte
added
Passed code review
and removed
needs content review
As a preparation to migrate the country into 2-outcomes, I am flattening the content to 18, so the migration will be easier. All regression tests are passing, so I am confident that I have not broken anything.
Once the content is flattened there is code that is no longer reachable, hence can be removed
Removes all artefacts that only applied when we had 18 outcomes. It add two artefacts, opposite and same sex for Thailand. The files marriage-abroad-responses-and-expected-results.yml is updated as the flow for Thailand has changed.
Few headings weren't working.
leenagupte
force-pushed
the
marriage-abroad-2-outcomes-thailand
branch
from
81e36ff to
29d9ca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Description
Reduces to two outcomes Thailand
Factcheck
Factcheck URL
Expected changes
Before
After