Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate statutory sick pay: Content change request #3079

Merged

Conversation

ikennaokpala
Copy link
Contributor

@ikennaokpala ikennaokpala commented Jun 14, 2017

Trello card

Description

This PR replaces 'Additional Statutory Paternity Pay' answer with 'Shared Parental Leave and Pay'.

Factcheck

Preview link
GOV.UK

Expected change

  • Replacement of the option key and text
    • additional_statutory_paternity_pay key with shared_parental_leave_and_pay
    • 'Additional Statutory Paternity Pay' text with 'Shared Parental Leave and Pay'

Before

screen shot 2017-06-14 at 13 43 27

After

screen shot 2017-06-14 at 13 58 57

@ikennaokpala ikennaokpala added needs content review Waiting for a content designer to approve Ready for code review labels Jun 14, 2017
@cbaines
Copy link
Contributor

cbaines commented Jun 14, 2017

The before and after screenshot looks the same to me.

@ikennaokpala
Copy link
Contributor Author

ikennaokpala commented Jun 14, 2017

Ahh thanks for highlighting that.. I have fixed it

Copy link
Contributor

@cbaines cbaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a rough look at the diff, its rather large, but seems good to me 👍

@ikennaokpala ikennaokpala added Passed code review and removed needs content review Waiting for a content designer to approve Ready for code review labels Jun 14, 2017
@ikennaokpala ikennaokpala force-pushed the calculate-statutory-sick-pay/content-change-request branch from 76a9947 to 62d85d3 Compare June 14, 2017 14:40
This commit replaces the option key and text for
additional_statutory_paternity_pay for shared_parental_leave_and_pay.

These changes have been done upon request from the content team.
This commit updates the following YAML files:

- test/data/calculate-statutory-sick-pay-questions-and-responses.yml
- test/data/calculate-statutory-sick-pay-responses-and-expected-results.yml
This commit regenerates test artefacts for calculate-statutory-sick-pay.

This modification is reflected in one file and the rest are changes in
the file names.
@ikennaokpala ikennaokpala force-pushed the calculate-statutory-sick-pay/content-change-request branch from 62d85d3 to eb7875f Compare June 19, 2017 08:38
@ikennaokpala ikennaokpala merged commit 50d191a into master Jun 19, 2017
@ikennaokpala ikennaokpala deleted the calculate-statutory-sick-pay/content-change-request branch June 19, 2017 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants