Maternity Paternity Calculator: Implementation for Employee Adoption matching week #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikennaokpala
added
needs content review
ikennaokpala
force-pushed
the
maternity-paternity-calculator/adoption-calculation-for-employers
branch
from
c273484 to
77b0647
Compare
ikennaokpala
force-pushed
the
maternity-paternity-calculator/adoption-calculation-for-employers
branch
from
77b0647 to
78a4400
Compare
ikennaokpala
force-pushed
the
maternity-paternity-calculator/adoption-calculation-for-employers
branch
from
78a4400 to
3fae989
Compare
ikennaokpala
force-pushed
the
maternity-paternity-calculator/adoption-calculation-for-employers
branch
from
3fae989 to
ba03676
Compare
mgrassotti
approved these changes
Jul 17, 2017
ikennaokpala
added
Passed code review
and removed
needs content review
For adoption an employee has to be employed in the *matching week* to get Statutory Adoption Pay but maternity-paternity-calculator is using the first date in *qualifying week* (which is for maternity / paternity calculations) So the question: Was the employee (or will they be) on your payroll on [qualifying week]? Should say: Was the employee (or will they be) on your payroll on [start of matching week - ie the Sunday before the matching date]? This commit fixes this by adding an adoption_matching_week_start method that the Sunday before if the *qualifying week* isn't a Sunday and vice versa.
ikennaokpala
force-pushed
the
maternity-paternity-calculator/adoption-calculation-for-employers
branch
from
ba03676 to
0da73d6
Compare
ikennaokpala
deleted the
maternity-paternity-calculator/adoption-calculation-for-employers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Motivation
For adoption an employee has to be employed in the matching week to get Statutory Adoption Pay but maternity-paternity-calculator is using the first date in qualifying week (which is for maternity / paternity calculations)
So the question:
Was the employee (or will they be) on your payroll on [qualifying week]?
Should say:
Was the employee (or will they be) on your payroll on [start of matching week - ie the Sunday before the matching date]?
This PR fixes this by adding an adoption_matching_week_start method that the Sunday before if the qualifying week isn't a Sunday and vice versa.
Factcheck
Preview link
GOVUK
Expected changes
Before
After
Other examples