Marriage abroad: Two outcome path for luxembourg #3174
Merged
+259
−1,866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikennaokpala
added
needs content review
ikennaokpala
force-pushed
the
marriage-abroad/2-outcome-path-for-luxembourg
branch
from
04ef373 to
ff9c50f
Compare
chao-xian
approved these changes
Aug 3, 2017
ikennaokpala
force-pushed
the
marriage-abroad/2-outcome-path-for-luxembourg
branch
from
ff9c50f to
45b979a
Compare
ikennaokpala
added
Waiting on factcheck
and removed
needs content review
This commit switches Luxembourg from an 18 to 2 outcome country. This include: - Moving Luxembourg to the 2 outcome country list - Adding opposite and same sex partials (this will be updated later) - Updating the responses and expected response yaml file - Updating the integration tests The aforementioned changes have made the erb templates under ceremony_country third_country and uk redundant and affected the regression test artefacts. These will be removed and updated in comming commits respectively.
Sequel to the commit before this, this commit introduces the two outcome paths: - /marriage-abroad/y/luxembourg/opposite_sex - /marriage-abroad/y/luxembourg/same_sex It removes the following redundant erb templates: - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/ceremony_country/partner_british/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/ceremony_country/partner_british/_same_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/ceremony_country/partner_local/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/ceremony_country/partner_local/_same_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/ceremony_country/partner_other/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/ceremony_country/partner_other/_same_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/third_country/partner_british/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/third_country/partner_british/_same_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/third_country/partner_local/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/third_country/partner_local/_same_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/third_country/partner_other/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/third_country/partner_other/_same_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/uk/partner_british/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/uk/partner_british/_same_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/uk/partner_local/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/uk/partner_local/_same_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/uk/partner_other/_opposite_sex.erb - lib/smart_answer_flows/marriage-abroad/outcomes/countries/luxembourg/uk/partner_other/_same_sex.erb And also no longer supports the following 18 outcome paths: - /marriage-abroad/y/luxembourg/ceremony_country/partner_british/opposite_sex - /marriage-abroad/y/luxembourg/ceremony_country/partner_british/same_sex - /marriage-abroad/y/luxembourg/ceremony_country/partner_local/opposite_sex - /marriage-abroad/y/luxembourg/ceremony_country/partner_local/same_sex - /marriage-abroad/y/luxembourg/ceremony_country/partner_other/opposite_sex - /marriage-abroad/y/luxembourg/ceremony_country/partner_other/same_sex - /marriage-abroad/y/luxembourg/third_country/partner_british/opposite_sex - /marriage-abroad/y/luxembourg/third_country/partner_british/same_sex - /marriage-abroad/y/luxembourg/third_country/partner_local/opposite_sex - /marriage-abroad/y/luxembourg/third_country/partner_local/same_sex - /marriage-abroad/y/luxembourg/third_country/partner_other/opposite_sex - /marriage-abroad/y/luxembourg/third_country/partner_other/same_sex - /marriage-abroad/y/luxembourg/uk/partner_british/opposite_sex - /marriage-abroad/y/luxembourg/uk/partner_british/same_sex - /marriage-abroad/y/luxembourg/uk/partner_local/opposite_sex - /marriage-abroad/y/luxembourg/uk/partner_local/same_sex - /marriage-abroad/y/luxembourg/uk/partner_other/opposite_sex - /marriage-abroad/y/luxembourg/uk/partner_other/same_sex
This commit updates the opposite and same sex outcomes for Luxembourg The update has been carry out based on instructions received from the content design team. The outcome paths affected by these changes are: - /marriage-abroad/y/luxembourg/opposite_sex - /marriage-abroad/y/luxembourg/same_sex
ikennaokpala
force-pushed
the
marriage-abroad/2-outcome-path-for-luxembourg
branch
from
45b979a to
cfc4ff7
Compare
This content update changes the country from France to Luxembourg and enumerates the possible card companies that are accepted for payments. Checksum and regression test artefacts have been updated.
ikennaokpala
deleted the
marriage-abroad/2-outcome-path-for-luxembourg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Description
This pull request reduces Luxembourg to 2 outcome paths:
Content design team have provided the content which have also been included.
Factcheck
Preview link
GOVUK
Expected changes
Before
After