Create one outcome per path for Nicaragua #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrassotti
changed the title
mgrassotti
force-pushed
the
flatten-nicaragua
branch
from
3285805 to
86f63f4
Compare
mgrassotti
force-pushed
the
flatten-nicaragua
branch
from
86f63f4 to
11f9480
Compare
mgrassotti
force-pushed
the
flatten-nicaragua
branch
from
11f9480 to
13edb0e
Compare
mgrassotti
force-pushed
the
flatten-nicaragua
branch
from
13edb0e to
1506621
Compare
mgrassotti
force-pushed
the
flatten-nicaragua
branch
from
1506621 to
0f11cea
Compare
mgrassotti
force-pushed
the
flatten-nicaragua
branch
from
0f11cea to
fbcb353
Compare
ikennaokpala
suggested changes
Sep 5, 2017
There was a problem hiding this comment.
@mgrassotti I noticed the tests only cover ceremony
and third country /partner other routes.. what about the rest. I suggest that all possible paths be covered with tests.
|
@ikennaokpala 👍 let me know if that is ok now |
mgrassotti
force-pushed
the
flatten-nicaragua
branch
from
b797096 to
a66a87f
Compare
mgrassotti
force-pushed
the
flatten-nicaragua
branch
from
a66a87f to
702ad2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the maintenance of marriage abroad smart answers, we are going to create one outcome per path for Nicaragua.
Trello: https://trello.com/c/BqtzqHmG/738-marriage-abroad-create-one-outcome-per-path-for-nicaragua