Improve integration test reliability #7131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtaylorgds
force-pushed
the
add-waits-to-integration-tests
branch
from
16d7824 to
c20f4b7
Compare
Following a recent release of Chrome/Chromium, integration tests have become less reliable. It seems like when a page change occurs (for example, when visiting a URL, or after submitting a form) the new page is less likely to have loaded by the time the next line in the test occurs than was previously the case. The Capybara `find` method waits (with a timeout) for the specified element, so this commit updates all of the integration tests to add an appropriate `find` call after a page transition (or, in the case of no page transition but a validation message being expected, a `find` for that error message).
mtaylorgds
force-pushed
the
add-waits-to-integration-tests
branch
from
c20f4b7 to
7ad21dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a recent release of Chrome/Chromium, integration tests have become less reliable. It seems like when a page change occurs (for example, when visiting a URL, or after submitting a form) the new page is less likely to have loaded by the time the next line in the test occurs than was previously the case.
The Capybara
findmethod waits (with a timeout) for the specified element, so this commit updates all of the integration tests to add an appropriatefindcall after a page transition (or, in the case of no page transition but a validation message being expected, afindfor that error message).