Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow fix #44

Closed
wants to merge 1 commit into from
Closed

Overflow fix #44

wants to merge 1 commit into from

Conversation

TBK
Copy link
Contributor

@TBK TBK commented Feb 23, 2020

Potential solution for #37, I have only done minimal testing.

@TBK TBK requested a review from clandmeter February 23, 2020 14:04
@TBK
Copy link
Contributor Author

TBK commented Feb 23, 2020

hmm straight up removing overflow-x: auto; might also be the solution.

@TBK TBK changed the title Set min-height for .table-responsive #35 overflow fix Feb 23, 2020
@TBK TBK changed the title #35 overflow fix Overflow fix Feb 23, 2020
@TBK
Copy link
Contributor Author

TBK commented Feb 23, 2020

From my understanding the only reason for overflow-x is to create a "mobile experience".

Which causes issues for big screen devices. A css media rule could limit it to the "mobile experience".

@algitbot
Copy link

Merged in 0d5d4aa by @clandmeter. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this Mar 26, 2020
@TBK TBK deleted the overflow branch March 26, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants