Add motor temperature sensor support to SensorBridge and YarpSensorBridge and logger #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
reviewed
Mar 7, 2025
|
|
||
| if (jointVelocties.size() != m_pimpl->controlBoardRemapperMeasures.jointVelocities.size()) | ||
| { | ||
| log()->error("[YarpSensorBridge::getJointVelocities] Joint velocities and positions have " |
There was a problem hiding this comment.
Is the message correct?
Aren't you checking if the input velocity has the right dimension?
| if (jointAccelerations.size() | ||
| != m_pimpl->controlBoardRemapperMeasures.jointAccelerations.size()) | ||
| { | ||
| log()->error("{} Joint accelerations and positions have different sizes.", logPrefix); |
| = m_pimpl->controlBoardRemapperMeasures.receivedTimeInSeconds; | ||
|
|
||
| return true; | ||
| } |
GiulioRomualdi
force-pushed
the
motor_temperature
branch
from
8c7ce23 to
8e5957e
Compare
…rBridge and YarpRobotLoggerDevice
S-Dafarra
approved these changes
Mar 10, 2025
S-Dafarra
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigates #819 in the case of motor temperature. Thanks to robotology/yarp#3188, the motor temperature will now be streamed in
stateExt, eliminating the need for RPC calls betweencontrolboard_nwsandRemoteControlBoard.