Code

Improve video poster image handling#2240

Code

Merged

swissspidy merged 8 commits intoamp-stories-reduxampproject/amp-wp:amp-stories-reduxfrom fix/video-poster-imageampproject/amp-wp:fix/video-poster-imageCopy head branch name to clipboardMay 3, 2019

+59-26

Commits

Commits on May 2, 2019

• Set default poster image background position to 50%/50% instead of invalid value cover

  westonruter

  committed
  05adb66

  Copy full SHA for 05adb66

• Show video in editor instead of poster image

  westonruter

  committed
  86d20ee

  Copy full SHA for 86d20ee

• Re-use featured image UI for representing story background video poster

  westonruter

  committed
  901d482

  Copy full SHA for 901d482

• Use 'set' instead of 'supplied' for poster image notice

  westonruter

  committed
  a6848b4

  Copy full SHA for a6848b4

• Remove obsolete fallback value for backgroundPosition

  westonruter

  committed
  c41bd8d

  Copy full SHA for c41bd8d

• Use classnames() for readability

  westonruter

  committed
  2b53dd9

  Copy full SHA for 2b53dd9

Commits on May 3, 2019

• If a video has a featured image, set as poster automatically

  swissspidy

  committed
  e3d92a5

  Copy full SHA for e3d92a5

• Simplify strings and UI elements

  swissspidy

  committed
  e792c92

  Copy full SHA for e792c92