use pointers to bools #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be able to tell the difference between a false value, and an
unset value. Even though this change might make the UX kinda ugly if one
were to set the bools directly (e.g. `&[]bool{true}[0]`), it does make
the library more robust against future changes to the protocol.
|
addresses #27 |
andreykaipov
added a commit
that referenced
this pull request
Dec 14, 2021
should have been part of PR #29
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to tell the difference between a false value, and an
unset value. Even though this change might make the UX kinda ugly if one
were to set the bools directly (e.g.
&[]bool{true}[0]), it does makethe library more robust against future changes to the protocol.