fix(tabs): remove unused dependency injections

[bekos]

Just noticed it :-)

[gdennie]

Note: the bower.json (and package installation) suggest that angular-ui is not dependent on "bootstrap" as it does not list it as a dependency. Additionally, my reading also suggest that some of angular-ui's components are dependent on jQuery as well.

I don't know what efficiency are gained by misinforming about the dependencies; but, for us newbies, it is frustrating.

[pkozlowski-opensource]

@gdennie I hope that you are not suggesting that we do misinform users. If you take a look at the project's homepage it reads:

This repository contains a set of native AngularJS directives based on Twitter Bootstrap's markup and CSS. As a result no dependency on jQuery or Bootstrap's JavaScript is required

and the project's tagline reads:

Native AngularJS (Angular) directives for Twitter's Bootstrap. Small footprint (5kB gzipped!), no 3rd party JS dependencies (jQuery, bootstrap JS) required!

I'm not sure how to make it more clear, but if you can prepare a pull request with documentation clarifications it would be gladly accepted, provided that it is accurate.

As for dependencies - unfortunately Bootstrap doesn't provide a package with its CSS only (or at least I'm not aware of any) so adding a dependency on the current bootstrap packages would pull its JavaScript and jQuery which is clearly not what we want in this project.

I'm not sure what you are referring to in this sentence: "Additionally, my reading also suggest that some of angular-ui's components are dependent on jQuery as well.". Clearly components from this repository do not require jQuery. Could you point to your reading source?

Maybe let's try to turn your frustration into something positive, OK?

[gdennie]

Thank you for responding so quickly...while the topic is still of-mind.

On the page, https://github.com/angular-ui/angular-ui#requirements, at this moment the jQuery dependency is noted.

It would also be useful to note here that the BootStrap CSS is a dependency as well. That was the poorly expressed heart of my complaint. Perhaps there could also be mention that the rest of the bootstrap repository is not needed.

Incidentally, my complaint is a sign that I have found the work valuable - even the documentation :). In particular, I would not have been as frustrated by something I found useless, unnecessary, or easily replaced.

...but I now notice a new site: https://github.com/angular-ui/ui-utils#requirements

[hallister]

@gdennie Angular UI is not UI Bootstrap they are just under the same organization. If you look at the UI Bootstrap docs the very first thing you'll read are the dependencies:

http://angular-ui.github.io/bootstrap/

Angular UI is the umbrella organization over a number of tools with a number of dependencies, one such tool is called Angular UI. Think of it as Google makes a search product that everyone calls Google and an email client (Gmail). In the same sense Angular UI makes a product that everyone calls Angular UI and a bootstrap client (UI Bootstrap).

[gdennie]

Oh.