This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(modal): put backdrop in before window #1313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thnx! |
|
Thank you! — On Fri, Nov 29, 2013 at 9:47 AM, Pawel Kozlowski notifications@github.com
|
chrisirhc
pushed a commit
to chrisirhc/angular-ui-bootstrap
that referenced
this pull request
Dec 17, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this compiles and inserts the backdrop before the window object. this change was previously accepted and then reverted by recent changes. putting the backdrop first in the dom allows the natural stacking order to stack the modals. it also gives users (who may be overriding the tpls) the chance to set z index first on the backdrop before setting it on window. this is helpful if you have a global notion of next highest z index.